On 6/7/26 17:38, Naveen Kumar Chaudhary wrote:
msm_serial_pending() has an unreachable 'return 0' after a complete
if/else where both branches already return. Remove the else keyword
and the dead return statement, simplifying the control flow.
Signed-off-by: Naveen Kumar Chaudhary <[email protected]>
---
drivers/serial/serial_msm_geni.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/serial/serial_msm_geni.c b/drivers/serial/serial_msm_geni.c
index 3dca581f68f..ece2a722068 100644
--- a/drivers/serial/serial_msm_geni.c
+++ b/drivers/serial/serial_msm_geni.c
@@ -428,11 +428,9 @@ static int msm_serial_pending(struct udevice *dev, bool
input)
if (input)
return readl(priv->base + SE_GENI_RX_FIFO_STATUS) &
RX_FIFO_WC_MSK;
- else
- return readl(priv->base + SE_GENI_TX_FIFO_STATUS) &
- TX_FIFO_WC_MSK;
- return 0;
+ return readl(priv->base + SE_GENI_TX_FIFO_STATUS) &
+ TX_FIFO_WC_MSK;
}
static const struct dm_serial_ops msm_serial_ops = {
Reviewed-by: Neil Armstrong <[email protected]>
Thanks,
Neil
