Hi Naveen, Thank you for the patch.
On Tue, Sep 01, 2026 at 15:49, Naveen Kumar Chaudhary <[email protected]> wrote: > The AVB_ORANGE case fell through into AVB_RED due to a missing break. > It happened to be harmless since AVB_RED only breaks, but it trips > -Wimplicit-fallthrough and is fragile against future changes. Add the > missing break. > > Fixes: 5d4fd877733 ("avb2.0: add boot states and dm-verity support") Fixes: 5d4fd877733 ("avb2.0: add boot states and dm-verity support") Checkpatch.pl seems to warn here: $ ./scripts/checkpatch.pl --git HEAD^..HEAD WARNING: Please use correct Fixes: style 'Fixes: <12+ chars of sha1> ("<title line>")' - ie: 'Fixes: 5d4fd8777337 ("avb2.0: add boot states and dm-verity support")' #11: So please replace this with: Fixes: 5d4fd8777337 ("avb2.0: add boot states and dm-verity support") (there is a missing '7' at the end of the sha1 in the original commit message) Do you want to send a v2 with this fixed, or should I do the commit message fixup when merging the patch into my tree? > Signed-off-by: Naveen Kumar Chaudhary <[email protected]> > --- > common/avb_verify.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/common/avb_verify.c b/common/avb_verify.c > index b96cd1ebd7b..09f1534c3cc 100644 > --- a/common/avb_verify.c > +++ b/common/avb_verify.c > @@ -198,6 +198,7 @@ char *avb_set_state(AvbOps *ops, enum avb_boot_state > boot_state) > break; > case AVB_ORANGE: > cmdline = "androidboot.verifiedbootstate=orange"; > + break; The change looks good to me, so: Reviewed-by: Mattijs Korpershoek <[email protected]> > case AVB_RED: > break; > } > -- > 2.43.0
