Check the return value of dev_read_addr_ptr() for NULL instead of
IS_ERR(). This function only ever returns NULL on failure.

Add <errno.h>, since this is the first error code used directly
in this file.

Fixes: bf57dd5889be ("drivers: phy: add Innosilicon DSI-DPHY driver")
Signed-off-by: David Lechner <[email protected]>
---
 drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c 
b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
index 5be76e05339..9aaca8a50e3 100644
--- a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
+++ b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
@@ -9,6 +9,7 @@
 #include <dm/device_compat.h>
 #include <dm/devres.h>
 #include <div64.h>
+#include <errno.h>
 #include <generic-phy.h>
 #include <linux/kernel.h>
 #include <linux/iopoll.h>
@@ -625,8 +626,8 @@ static int inno_dsidphy_probe(struct udevice *dev)
        inno->pdata = (const struct inno_video_phy_plat_data 
*)dev_get_driver_data(dev);
 
        inno->phy_base = dev_read_addr_ptr(dev);
-       if (IS_ERR(inno->phy_base))
-               return PTR_ERR(inno->phy_base);
+       if (!inno->phy_base)
+               return -EINVAL;
 
        inno->ref_clk = devm_clk_get(dev, "ref");
        if (IS_ERR(inno->ref_clk)) {

-- 
2.43.0

Reply via email to