Hi,

> USB OTG port is not enabled in DT, so CMD_ROCKUSB and CMD_USB_MASS_STORAGE
> may not be needed unless there is pending DT updates that will enable
> use of USB OTG port.

> The DWC3 node is not enabled in DT, so USB_XHCI_HCD, USB_DWC3 and 
> USB_DWC3_GENERIC may not be needed unless there is pending DT updates
> that will enable use of the OTG port.

> Only the USB HOST port is enabled in DT, do we need these USB gadget
> related Kconfig options?

I removed the USB OTG / DWC3 / GADGET options.

> clock-names is not included in this lists for new boards, please drop
> clock-names form the list of properties to be removed from SPL.

Removed clock-names from CONFIG_OF_SPL_REMOVE_PROPS.

> The combphy seems to be used for PCIe in the DT, maybe we should enable
> following Kconfig options:

> CONFIG_PCI=y
> CONFIG_PCIE_DW_ROCKCHIP=y
> CONFIG_CMD_PCI=y

> along with correct PCIe Ethernet driver.

I added these and enabled CONFIG_RTL8169, but it doesn't seem
to be working.

Thanks,
Chukun

Reply via email to