On Sun, Sep 06, 2026 at 12:48:45PM +0800, Pengpeng Hou wrote:
> The RG-DS target is named TARGET_ANBERNIC_RG_DS_RK3568, but the board
> Kconfig tests the undefined TARGET_RG_DS_RK3568 symbol.  The board
> specific defaults therefore never apply.
> 
> In particular, SYS_CONFIG_NAME falls back to rk3568_common instead of
> selecting anbernic-rg-ds-rk3568.  This omits the board header which adds
> the serial and video console settings.
> 
> Use the actual RG-DS target symbol.  Keep it distinct from the RGXX3
> target as discussed during review of the original board support.
> 
> Fixes: 1998fe69f7e1 ("board: rockchip: add Anbernic RG-DS")
> Link: 
> https://lore.kernel.org/u-boot/[email protected]/
> Signed-off-by: Pengpeng Hou <[email protected]>
> ---
> Testing:
> - Generated anbernic-rg-ds-rk3568_defconfig and verified that
>   CONFIG_SYS_CONFIG_NAME selects anbernic-rg-ds-rk3568.
> 
>  board/anbernic/rg-ds_rk3568/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/anbernic/rg-ds_rk3568/Kconfig 
> b/board/anbernic/rg-ds_rk3568/Kconfig
> index 867694065..1d1043f8c 100644
> --- a/board/anbernic/rg-ds_rk3568/Kconfig
> +++ b/board/anbernic/rg-ds_rk3568/Kconfig
> @@ -1,4 +1,4 @@
> -if TARGET_RG_DS_RK3568
> +if TARGET_ANBERNIC_RG_DS_RK3568
>  
>  config SYS_BOARD
>       default "rg-ds_rk3568"
> 

Somehow I missed this on the upstream, but it is on my local branch.
Good catch and thank you.

-Chris

Reply via email to