Hi Dinesh,
On Tue, 30 Jun 2026 14:55:18 +0800, [email protected] wrote:
diff --git a/arch/arm/mach-socfpga/rsu_s10.c b/arch/arm/mach-socfpga/rsu_s10.c
@@ -0,0 +7,32 @@
+#include <limits.h>
+#include <linux/compiler.h>
+#include <linux/errno.h>
+#include <linux/kernel.h>
+#ifdef CONFIG_DM_SPI_FLASH
+#include <dm/device.h>
+#endif
+#include <asm/arch/mailbox_s10.h>
+#include <asm/arch/rsu.h>
+#include <asm/arch/rsu_s10.h>
+#include <command.h>
+#include <rsu_console.h>
+#include <vsprintf.h>
+#include <spi.h>
+#include <spi_flash.h>
+#include <env.h>
+#include <fdt_support.h>
+#include <asm/arch/rsu_flash_if.h>
+
+DECLARE_GLOBAL_DATA_PTR;
+
+#define RSU_S10_SPT_SLOT_MAX 127
+
+/* Linux DTB label identifying the RSU-managed boot partition. */
+#define RSU_BOOT_PARTITION_LABEL "Boot and fpga data"
+
+static unsigned int rsu_s10_spt_entry_count(const struct socfpga_rsu_s10_spt
*spt)
+{
+ if (spt->magic_number != RSU_S10_SPT_MAGIC_NUMBER)
+ return 0;
+ if (spt->entries > RSU_S10_SPT_SLOT_MAX)
+ return RSU_S10_SPT_SLOT_MAX;
checkpatch wants IS_ENABLED() instead of #ifdef CONFIG_DM_SPI_FLASH
(checkpatch CP-W).
checkpatch --u-boot reported 39 warnings, mostly CONFIG_IS_ENABLED /
IS_ENABLED vs #ifdef. Cover says checkpatch reports no errors (true: 0
errors). The remaining warnings are style, not merge blockers.
Please: Replace #ifdef CONFIG_DM_SPI_FLASH and similar with if
(IS_ENABLED(CONFIG_DM_SPI_FLASH)) or CONFIG_IS_ENABLED() as checkpatch
suggests.
[...]
Best regards,
Tien Fong
