Hi Quentin,
Thank you for the review.
On 10/16/26, Quentin Schulz wrote:
> On 10/10/26 3:32 AM, Shigeaki Asai wrote:
>> + { 1800000, 100000, REG_BOOST_LDO9_ON_VSEL, REG_BOOST_LDO9_SLP_VSEL, NA,
>> + RK818_LDO_VSEL_MASK, },
>
> Please stay consistent with the rest of the file where we have
> everything on the same line.
OK, I will put it on one line in v2.
>> + if (priv->variant == RK818_ID && ldo == 8) {
>> + mask = RK818_LDO9_EN_MASK;
>> + ret = pmic_reg_read(pmic, REG_DCDC_EN);
>> + } else {
>> + mask = 1 << ldo;
>> + ret = pmic_reg_read(pmic, REG_LDO_EN);
>> + }
>
> This is not great, I would prefer to have some additional configuration
> in rk8xx_reg_info instead, but since we do it for many other cases
> already, nothing for you to do on this issue in this patch.
I understand, thank you.
> Reviewed-by: Quentin Schulz <[email protected]>
Thank you. I will keep your Reviewed-by in v2.
I will drop patch 2/2 (see my reply there), so I plan to send v2 of
this patch alone, after waiting a few days for other comments.
Best regards,
Shigeaki Asai
(This reply was written with the help of Claude.)
