Hi Jan,
Two minor things, neither of which needs to block this.
On Thu, Oct 15, 2026 at 04:22:19PM +0200, Jan Kiszka wrote:
> + val = ms * 1000000ULL / 983040;
On rv32 this is a 64-bit division, so i6300esb-wdt.o ends up with an
undefined __udivdi3 (seen with qemu-riscv32_smode_defconfig plus
WDT_I6300ESB). lldiv() from <div64.h> avoids depending on libgcc for
it (checked that the object then has no __udivdi3 reference):
val = lldiv(ms * 1000000ULL, 983040);
> + if (wdt->base == NULL)
> + return -EINVAL;
checkpatch suggests "if (!wdt->base)" here.
Otherwise this works fine on qemu-riscv64, see my reply to 3/3:
Tested-by: Hung-Chun Tseng <[email protected]> # qemu-riscv64 S-mode
Thanks,
Hung-Chun
