Hi David
David Lechner 於 2026/10/13 上午 05:20 寫道:
On 10/12/26 11:26 AM, Lucien.Jheng wrote:
From: "Lucien Jheng" <[email protected]>
include/dt-bindings/clock/mt7986-clk.h duplicates the binding header
that is already provided by dts/upstream/include/. Since the U-Boot
include/ directory precedes dts/upstream/include/ in UBOOTINCLUDE, the
local copy shadows the upstream one regardless of CONFIG_OF_UPSTREAM.
Nice cleanup, thanks.
@@ -526,7 +526,7 @@ static const struct mtk_gate infracfg_gates[] = {
static const struct mtk_clk_tree mt7986_fixed_pll_clk_tree = {
.ext_clk_rates = ext_clock_rates,
.num_ext_clks = ARRAY_SIZE(ext_clock_rates),
- .fdivs_offs = CLK_APMIXED_NR_CLK,
+ .fdivs_offs = ARRAY_SIZE(fixed_pll_clks),
I noticed this is actually no longer needed and we have the same thing in a
couple of other files. So I sent out [1] to take care of that. So I will
apply 1 first and then this patch so that this line change goes away (after
the customary 2 week review period).
I'll update the patch once your commit is merged into U-Boot.
Thanks
[1]:
https://lore.kernel.org/u-boot/20261012-clk-mediatek-apmixed-fdivs-offs-v1-1-f366cc5dd...@baylibre.com/
.fclks = fixed_pll_clks,
.num_fclks = ARRAY_SIZE(fixed_pll_clks),
.flags = CLK_PARENT_APMIXED,
