Hi Dario,
On 29.10.26 17:05, Dario Binacchi wrote:
> ddr_init() is called from board_init_f(), before .bss is cleared, so
> ddrmix_initialized may already be non-zero on the first call. The DDRMIX
> cold reset is then run on a DDRMIX that has never been initialized and
> the SPL hangs (with DEBUG enabled in ddr_init.c):
>
> DDRINFO: start DRAM init
> DDRINFO: cold reset the DDRMIX
>
> Move ddrmix_initialized to .data, so that it is zero on the first call.
>
> Fixes: ae03528affd3 ("ddr: imx: Recreate the power-on state before repeating
> ddr_init()")
> Signed-off-by: Dario Binacchi <[email protected]>
This issue didn't show up in my tests on i.MX8MM and i.MX8MP, but it
looks correct to me.
Thanks for fixing this!
Reviewed-by: Frieder Schrempf <[email protected]>
Best regards
Frieder
>
> ---
>
> drivers/ddr/imx/imx8m/ddr_init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ddr/imx/imx8m/ddr_init.c
> b/drivers/ddr/imx/imx8m/ddr_init.c
> index b2873ab439d7..154e9d887465 100644
> --- a/drivers/ddr/imx/imx8m/ddr_init.c
> +++ b/drivers/ddr/imx/imx8m/ddr_init.c
> @@ -48,7 +48,7 @@
> #define CCGR_DDRMIX CCGR_DDR1
> #endif
>
> -static bool ddrmix_initialized;
> +static bool ddrmix_initialized __section(".data");
>
> static unsigned int g_cdd_rr_max[4];
> static unsigned int g_cdd_rw_max[4];
> ---
> base-commit: 03e45557e1f38a39a0c80fe30483130ff376cf92
> branch: imx8m-ddrmix-initialized-data
>
