Hi Heinrich,

On 10/30/26 12:15, Heinrich Schuchardt wrote:
> We continue to use
>
> IMAGE_NT_HEADERS32 *nt;
>
> though we check against IMAGE_NT_HEADERS64.
>
> Shouldn't we be more consistent and use the same type everywhere in the
> function?

Yes. efi_check_pe() only reads the signature, which sits at the same
offset in both, so in v2 I'll declare nt as IMAGE_NT_HEADERS64 * and
check the size against sizeof(*nt).

Thanks for the review,
Ana

Reply via email to