On Fri, Oct 30, 2026 at 07:11:44PM +0530, Aswin Murugan wrote: > The Qualcomm SDHCI driver lacked DLL init/calibration and tuning > support, so it never negotiated above high-speed/DDR52. Add the > CM_DLL init/phase-tuning sequence for HS200 and the SDC4 DLL > calibration for HS400, matching the SDCC core generation variants > already distinguished in this driver. > > Tested-by: Igor Opaniuk <[email protected]> > Signed-off-by: Aswin Murugan <[email protected]> > --- > Change in v3: > - guard execute_tuning under CONFIG_MMC_SUPPORTS_TUNING to fix > undefined reference to mmc_send_tuning when tuning is disabled > --- > drivers/mmc/msm_sdhci.c | 749 +++++++++++++++++++++++++++++++++++++++- > 1 file changed, 748 insertions(+), 1 deletion(-)
You're adding 748 lines to a 358 line file? That doesn't make it an outlier, but that's *a lot*. And that's a lot to review. Can this be broken up in to logical chunks? Should we follow the example of some other drivers and introduce drivers/mmc/msm_sdhci.h so the driver itself can be better structured? Is there anything in here that we're hard-coding but should be able to pull out of the device tree instead? -- Tom
signature.asc
Description: PGP signature
