Hi Simon, On 10/31/2026 10:33 AM, Simon Glass wrote: > Hi Jonas, > > On 2026-10-11T22:28:36, Jonas Karlman <[email protected]> wrote: > >> Some of these fixes have only been compile tested as it involves clocks >> or rates that are rarely used in U-Boot. > > Please can you say which patches were tested on hardware, and on which > boards? Patches 1 to 6 and 14 change PLL and bus-clock setup that > every RK3568/RK3576/RK3588 board runs at boot, so they carry more risk > than the one-line copy-paste fixes. Knowing which ones still need a > run on real hardware would help the people testing on the various > SoCs.
All patches have been runtime tested on multiple boards of the affected SoCs, however a few of the fixes affect clocks or rates that no board or SoC is likely to use, e.g. VOP clocks or clock rates that board DTs or drivers is very unlikely to request. So technically some of the fixes have not been fully tested during runtime. > >> This series fixes a few trivial copy-paste mistakes and other misc clock >> issues for RK35xx SoCs. > > Within each SoC the fixes are mixed with cosmetic changes (the macro > renames and removals, the PLL-table alignment, SPLL_HZ and the GRF > lookup drops). Several of the cosmetic ones carry a Fixes: tag even > though they don't change behaviour, e.g. the PPLL macro renames, the > unused-macro removals and the PWM0 shift change, whose commit message > says as much. Some/most of the Fixes tags where added at request of Quentin. Most of the issues where discovered during a conversion of these drivers to use FIELD_GET/FIELD_PREP, and most looked like simple copy-paste errors. > It would be worth moving the real fixes to the front of > the series and keeping Fixes: only on patches that change behaviour. > Then the fixes can be picked up (and backported) on their own, while > the tidy-ups wait for the next merge window. What do you think? Fixes patches are already placed first within each soc-grouping, would likely split this series per such grouping if there is a need for a v3. Regards, Jonas > > Regards, > Simon
