Hi Tom,
On 10/30/2026 8:00 PM, Tom Rini wrote:
On Wed, Oct 28, 2026 at 11:24:31PM -0700, Abhilash V wrote:
From: KR Sowmiya <[email protected]>
Add support for loading the Config/Chip Data Table (CDT) from eMMC
during the Shikra SPL boot flow and registering it with QCLIB via
the interface table.
Signed-off-by: KR Sowmiya <[email protected]>
Signed-off-by: Abhilash V <[email protected]>
---
arch/arm/mach-snapdragon/Kconfig | 73 ++++++++++++++++
arch/arm/mach-snapdragon/board_spl.c | 96 +++++++++++++++++++++
arch/arm/mach-snapdragon/include/mach/spl.h | 1 +
arch/arm/mach-snapdragon/qclib.c | 8 ++
board/qualcomm/shikra/spl-shikra.c | 10 +++
5 files changed, 188 insertions(+)
diff --git a/arch/arm/mach-snapdragon/Kconfig b/arch/arm/mach-snapdragon/Kconfig
index 9e23d6d8948..7f5a9eecb7e 100644
--- a/arch/arm/mach-snapdragon/Kconfig
+++ b/arch/arm/mach-snapdragon/Kconfig
@@ -76,6 +76,79 @@ config QCOM_HWDETECT
Hardware parameter detection from SMEM and TCSR for
DTB selection and other platform subsystems.
+config QCOM_SPL_CDT_SUPPORTED
+ bool "Enable CDT support in SPL"
+ depends on SPL
+ help
+ Enable support for reading the CDT off the boot medium during
+ SPL and staging it in IMEM, so that QCLIB can pick it up via
+ the interface table.
+
+if QCOM_SPL_CDT_SUPPORTED
+
+choice
+ prompt "CDT partition lookup method"
+ default QCOM_SPL_CDT_USE_PARTITION_NAME
+ help
+ Locate the CDT partition on the boot media either using partition
+ name or partition type GUID.
+
+config QCOM_SPL_CDT_USE_PARTITION_NAME
+ bool "Look up the CDT partition by GPT partition name"
+ depends on SPL_PARTITIONS
+ help
+ Locate the CDT partition on the boot medium by its GPT partition
+ name (CONFIG_QCOM_SPL_CDT_PARTITION_NAME).
+
+config QCOM_SPL_CDT_USE_PARTITION_GUID
+ bool "Look up the CDT partition by GPT partition type GUID"
+ depends on SPL_PARTITION_TYPE_GUID
+ help
+ Locate the CDT partition on the boot medium by its GPT partition
+ type GUID (CONFIG_QCOM_SPL_CDT_PARTITION_GUID).
+
+endchoice
I think I made this comment on another patch? Since both options in a
choice depend on something else, QCOM_SPL_CDT_SUPPORTED needs to depend
on one of those other dependencies too. Please make sure your other
series don't have this issue as well, thanks.
Addressed the above comments in v4
https://lore.kernel.org/u-boot/[email protected]/
Regards,
Abhilash