> On 11/2/26 10:12 AM, [email protected] wrote:
> 
> Hello Kuwano-san,
> 
Hi Marek,

> >> From: Kenichi Nagai <[email protected]>
> >>
> >> Add IDs for Winbond W77T51NW, 512M-bit Secure Serial Flash Memory
> >> with Post-Quantum Cryptography, SPI, Quad, Octal and DTR . For
> >> details please see vendor page:
> >>
> >> https://www.winbond.com/hq/product/code-storage-flash/trustme-secure/w77t-nw/
> >>
> > Please use Link: tag.
> 
> Does Link tag apply to arbitrary links in the commit message ?
> 
> I believe Link tag only applies to lore links, hence I did not use it.
> 
I have been using Link: tag with datasheet link since [3].
I prefer to use the tag with datasheet link if it is publicly available in
vendor's site, but I won't push for it. 

> > Unfortunately, datasheet isn't publicly available...
> 
> Yes, I know.
> 
> > Is it possible to add board information you tested?
> 
> Retronix Sparrow Hawk , Renesas R-Car V4H SoC .
> 
Having a working board available is very helpful. Thank you.

> >> Signed-off-by: Kenichi Nagai <[email protected]>
> >> Signed-off-by: Marek Vasut <[email protected]>
> >> ---
> >> Cc: Kenichi Nagai <[email protected]>
> >> Cc: Takahiro Kuwano <[email protected]>
> >> Cc: Tom Rini <[email protected]>
> >> Cc: Vignesh R <[email protected]>
> >> Cc: Vincent Jardin <[email protected]>
> >> Cc: Yuya Hamamachi <[email protected]>
> >> Cc: [email protected]
> >> ---
> >>   drivers/mtd/spi/spi-nor-ids.c | 1 +
> >>   1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
> >> index 67486d7a945..fce22300b61 100644
> >> --- a/drivers/mtd/spi/spi-nor-ids.c
> >> +++ b/drivers/mtd/spi/spi-nor-ids.c
> >> @@ -670,6 +670,7 @@ const struct flash_info spi_nor_ids[] = {
> >>          { INFO("w25q01nw-im", 0xef8021, 0, 64 * 1024, 2048, SECT_4K | 
> >> SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> >>          { INFO("w25q02nw-im", 0xef8022, 0, 64 * 1024, 4096, SECT_4K | 
> >> SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> >>          { INFO("w77q51nw", 0xef8a1a, 0, 64 * 1024, 1024, SECT_4K | 
> >> SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> SPI_NOR_4B_OPCODES) },
> >> +       { INFO("w77t51nw", 0xef8e1a, 0, 64 * 1024, 1024, SECT_4K | 
> >> SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> SPI_NOR_4B_OPCODES) },
> >
> > It would be helpful to see how it differs from the existing w77q51nw.
>  From what I can find in [1] and [2], W77T is faster and wider than W77Q:
> - W77T is up to Octal-IO/200MHz
> - W77Q is up to Quad-IO /166MHz

Just out of curiosity, do you plan to add Octal-IO support in the future?

> The security extras are unsupported by either U-Boot or Linux, and I do
> not know the details of the security extras of the W77T part, so I can
> not comment on that.
> 
> And of course, the ID differs too.
> 
> Do you have any particular detail in mind that you would like me to find
> out ?
> 
Nothing particularly. I understood the interface improvement in W77T. 

> Thank you for your help !
> 
Thank you!

Reviewed-by: Takahiro Kuwano <[email protected]>

> [1]
> https://www.winbond.com/hq/product/code-storage-flash/trustme-secure/w77t-nw/
> [2]
> https://www.winbond.com/hq/product/code-storage-flash/trustme-secure/w77q-nw/
> 
> --
> Best regards,
> Marek Vasut

[3] https://lore.kernel.org/linux-mtd/[email protected]/

Reply via email to