This patch applies cleanly, but I still don't believe it accomplishes
the goal of modifying validate.c so that encoding matches the other
deprecations.  As far as I can see, for other cases where a specific
entry is deprecated, the upstream authors have removed the entire
handlers for those sections from the source.  As we try not to have
significantly invasive patches in Ubuntu, I recommend that instead of
deleting these sections, you either wrap the entire section in a
comment, or prevent compilation if an #ifdef 0 .. #endif construction.
You no longer need the child functions, as you have defined TRUE for the
Encoding defnition (with { "Encoding", validate_string, TRUE },
/* 0.9.5: deprecated */).  This applies to both the section starting at
line 729 and the section starting at line 936.

-- 
Encoding is deprecated
https://bugs.launchpad.net/bugs/117180
You received this bug notification because you are a member of Ubuntu
Bugs, which is the bug contact for Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to