Joy Latten [2016-04-13 18:08 -0000]: > Started looking into those patch diffs... > for the openssl-1.0.2a-fips-ec.patch one, I had a bunch of undefined > symbols and so cleaned these up, causing my diff to be slightly off... my > bad.
Ah, that makes sense. > Oh, and also, that patch installed "fips/cavs/fips_ecdhvs.c and > fips/cavs/fips_ecdsavs.c which are testcases I did not want to include. I > ignored them, but should have just removed them in my cleanup patch. Is that really necessary? Adding two .c files seems rather harmless if nothing refers to it, i. e. removing them from the Makefile only (in the ubuntu patch) should suffice? > Do you agree that I should move these things into my cleanup patch? That would be good indeed, as it avoids confusion for the next person who looks at this why the patches are different. Please also update the Origin:, preferablyto the git.fedora ones as then they are one click away from comparing/for updating. Thank you! Martin -- Martin Pitt | http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1553309 Title: [FFe]: Include FIPS 140-2 into openssl package To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/openssl/+bug/1553309/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
