Hi Rafael,
Not so important but FYI your link in the description is broken - it
leads me to some weird catching site, not really an emulatortalk.info
with some content.
I like your tests in #12 and #18, but can you think and compare several
permutations of commits to non-active layers? Those should have worked
before as far as I read the comments.
What would that be base->s1->s2->s3 and then committing s3 to s2 ?
What about inactive guests, would it work then?
You are certainly more into the topic, so I'd like to ask you to create these
tests and check that these still behave as intended (or better).
This is meant to catch and issues where the change from:
if (topSource == &disk->src) {
to
if (top_meta == disk->backingChain) {
due to the backporting might cause issues.
Move these tests, together with just the commands of #12 into the SRU
Teamplate in the description then please. To ease the SRU Teams work.
If you find any other invocation of block commit (e.g. to non active)
that works today, list breaking that in regression potential please.
Other than that I really think the patch is fine, and what I asked for
can/should be done as part of the verification in proposed IMHO - that
said, sponsoring now (after a build test).
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1317491
Title:
virsh blockcommit hangs at 100%
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1317491/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
