Finishing Verification with @cpaelzer questions:

I like your tests in #12 and #18, but can you think and compare several
permutations of commits to non-active layers? Those should have worked
before as far as I read the comments.

What would that be base->s1->s2->s3 and then committing s3 to s2 ?

>> Demonstrated with 2, 3 and 4 snapshots ^^^^. Active can't be merged
by all other layers can. At the end you will always have AT LEAST a base
and the top layers (since the active can't be merged).

What about inactive guests, would it work then?

>> There is no way to merge volumes with inactive guests. It uses QEMU
block jobs and it needs to be running.

Move these tests, together with just the commands of #12 into the SRU
Teamplate in the description then please. To ease the SRU Teams work.

>> Doing right now.

If you find any other invocation of block commit (e.g. to non active)
that works today, list breaking that in regression potential please.

>> All layers in RO mode (intermediate status). Will do.

Considering this verified. Thank you Christian.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1317491

Title:
  virsh blockcommit hangs at 100%

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1317491/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to