I could be on a wild goose chase here.

But one of the prominent changes between 77 and 78 is the
backing_dev_info element of the queue turning into a pointer.


Part of the "bdi" changes in this bit:
++  * UbuntuKVM guest crashed while running I/O stress test with Ubuntu kernel
++    4.4.0-47-generic (LP: #1659111)

I believe from here: https://patchwork.kernel.org/patch/9547199/

For example this:

--- a/drivers/block/drbd/drbd_main.c
+++ b/drivers/block/drbd/drbd_main.c
@@ -2462,7 +2462,7 @@  static int drbd_congested(void *congested_data, int 
bdi_bits)
 
        if (get_ldev(device)) {
                q = bdev_get_queue(device->ldev->backing_bdev);
-               r = bdi_congested(&q->backing_dev_info, bdi_bits);
+               r = bdi_congested(q->backing_dev_info, bdi_bits);
                put_ldev(device);
                if (r)
                        reason = 'b';

But if I check the Ubuntu-specific code, that change does not seem to be
done everywhere:

$ zcat linux_4.4.0-78.99.diff.gz | grep bdi_congested.*backing_dev -B2 |
tail -n8

                        struct request_queue *q = bdev_get_queue(rdev->bdev);
 
-                       ret |= bdi_congested(&q->backing_dev_info, bits);
+                       ret |= bdi_congested(q->backing_dev_info, bits);
--
+               struct request_queue *q = bdev_get_queue(rs->dev[p].dev->bdev);
+
+               r |= bdi_congested(&q->backing_dev_info, bdi_bits);


Extracting only the "new" files, I find it here indeed:

$ mkdir foo; cd foo
$ patch -tp1 < ../linux_4.4.0-78.99.diff.gz
$ find . -name '*.c' | xargs grep -B2 bdi_congested.*backing_dev_info
./ubuntu/dm-raid4-5/dm-raid4-5.c-               struct request_queue *q = 
bdev_get_queue(rs->dev[p].dev->bdev);
./ubuntu/dm-raid4-5/dm-raid4-5.c-
./ubuntu/dm-raid4-5/dm-raid4-5.c:               r |= 
bdi_congested(&q->backing_dev_info, bdi_bits);


This is just an example of course, I believe there could be more "bdi" changes 
like that one that haven't been made.

Correct me if I'm wrong though. I've never done any kernel dev, so I
could be way off base here.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1691741

Title:
  Execute NX-protected page - 4.4.0-78-generic - kernel panic

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1691741/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to