Hi Joe,

The original intent of the patch was not forcing a 6Gbs drive down to
1.5Gbs after hotplug.

Noting,

SSTATUS = 275 = 0x113 = 0001 0001 0011

That corresponds to ACTIVE PM STATE | GEN1 SPEED | DEVICE DETECTED

spd = 1 (corresponds to 1.5Gbps)

One question, the print for mask came after these 2 lines of code,
right?

       /* unconditionally mask off the highest bit */
        bit = fls(mask) - 1;
        mask &= ~(1 << bit);

In your debug kernel, would please remove the following 2 lines of code
(so the code falls thru)

        if (spd > 1)
                mask &= (1 << (spd - 1)) - 1;
        else                                     <=====
                return -EINVAL;                  <===== Remove these 2 lines of 
code.

And finally, at the end __sata_set_spd_needed(), would you please print
out these values?

spd
target
*scontrol

The original patch didn't force changing mask, but, it does "return -EINVAL", I 
think it
may fix the problem just letting it fall thru to the end of 
sata_down_spd_limit(), but it would
still help to see the original debug values and these new ones with possible 
fix. Thank you.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1783906

Title:
  Linux 4.15 and onwards fails to initialize some hard drives

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1783906/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to