** Description changed:

- Ran ipmi-locate on a system running Focal.  ipmi-locate returns the info
- I expect to see, and then segfaults (no core dump that I'm aware of).
+ [Impact]
+ 
+  * A variable was badly initialized leading to a 0x0 pointer that was 
+    accessed and segfaulting the program. In older versions this was
+    hidden due to other fails leading to an early exit on such platforms 
+    (those we don't have to touch)
+ 
+  * The Patch was upstreamed and hereby backported (applies as-is) to
+ Focal
+ 
+ [Test Case]
+ 
+  * There might be more affected systems, but he one we know so far
+    are dell idrac6/9 so please test on those if possible.
+    Obviously "regression tests" can be done on any system.
+    - run ipmi-locate
+    - without the fix it will segfault
+ 
+ [Regression Potential]
+ 
+  * The initialization is done right at the beginning of the function
+    and not accessed until the bad one we remove. So any user of that
+    variable would have crashed. Due to that I think we can't regress a 
+    case that wasn't formerly segfaulting - which should be fine.
+    The one change of behavior is that if people just ran the command (not 
+    checking output) and checked RC for further actions it might now on 
+    some systems actually work and return a difference RC.
+ 
+ [Other Info]
+  
+  * n/a
+ 
+ ---
+ 
+ 
+ Ran ipmi-locate on a system running Focal.  ipmi-locate returns the info I 
expect to see, and then segfaults (no core dump that I'm aware of).
  
  ubuntu@mayapple:~$ sudo ipmi-locate --version
  ipmi-locate - 1.6.4
  Copyright (C) 2005-2015 FreeIPMI Core Team
  This program is free software; you may redistribute it under the terms of
  the GNU General Public License.  This program has absolutely no warranty.
  ubuntu@mayapple:~$ sudo ipmi-locate
  Probing KCS device using DMIDECODE... done
  IPMI Version: 2.0
  IPMI locate driver: DMIDECODE
  IPMI interface: KCS
- BMC driver device: 
+ BMC driver device:
  BMC I/O base address: 0xCA8
  Register spacing: 4
  
  Probing SMIC device using DMIDECODE... FAILED
  
  Probing BT device using DMIDECODE... FAILED
  
  Probing SSIF device using DMIDECODE... FAILED
  
  Probing KCS device using SMBIOS... FAILED
  
  Probing SMIC device using SMBIOS... FAILED
  
  Probing BT device using SMBIOS... FAILED
  
  Probing SSIF device using SMBIOS... FAILED
  
  Segmentation fault
  
- 
  On a machine running Bionic, it returns similar data but does not segfault 
afterwards:
  bladernr@weavile:~$ sudo ipmi-locate --version
  ipmi-locate - 1.4.11
  Copyright (C) 2005-2014 FreeIPMI Core Team
  This program is free software; you may redistribute it under the terms of
  the GNU General Public License.  This program has absolutely no warranty.
  bladernr@weavile:~$ sudo ipmi-locate
  Probing KCS device using DMIDECODE... done
  IPMI Version: 2.0
  IPMI locate driver: DMIDECODE
  IPMI interface: KCS
- BMC driver device: 
+ BMC driver device:
  BMC I/O base address: 0xCA2
  Register spacing: 1
  
  Probing SMIC device using DMIDECODE... FAILED
  
  Probing BT device using DMIDECODE... FAILED
  
  Probing SSIF device using DMIDECODE... FAILED
  
  Probing KCS device using SMBIOS... FAILED
  
  Probing SMIC device using SMBIOS... FAILED
  
  Probing BT device using SMBIOS... FAILED
  
  Probing SSIF device using SMBIOS... FAILED
  
  Probing KCS device using ACPI... done
  IPMI Version: 2.0
  IPMI locate driver: ACPI
  IPMI interface: KCS
- BMC driver device: 
+ BMC driver device:
  BMC I/O base address: 0xCA3
  Register spacing: 1
  
  Probing SMIC device using ACPI... FAILED
  
  Probing BT device using ACPI... FAILED
  
  Probing SSIF device using ACPI... FAILED
  
  Probing KCS device using PCI... FAILED
  
  Probing SMIC device using PCI... FAILED
  
  Probing BT device using PCI... FAILED
  
  Probing SSIF device using PCI... FAILED
  
  ProblemType: Bug
  DistroRelease: Ubuntu 20.04
  Package: freeipmi-tools 1.6.4-3ubuntu1
  ProcVersionSignature: User Name 5.4.0-26.30-generic 5.4.30
  Uname: Linux 5.4.0-26-generic x86_64
  ApportVersion: 2.20.11-0ubuntu27
  Architecture: amd64
  CasperMD5CheckResult: skip
  Date: Tue Apr 28 22:56:41 2020
  ProcEnviron:
-  TERM=screen-256color
-  PATH=(custom, no user)
-  XDG_RUNTIME_DIR=<set>
-  LANG=C.UTF-8
-  SHELL=/bin/bash
+  TERM=screen-256color
+  PATH=(custom, no user)
+  XDG_RUNTIME_DIR=<set>
+  LANG=C.UTF-8
+  SHELL=/bin/bash
  SourcePackage: freeipmi
  UpgradeStatus: No upgrade log present (probably fresh install)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1875771

Title:
  ipmi_locate segfault on Focal (Dell iDRAC6/9)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/freeipmi/+bug/1875771/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to