Due to inconsistent use of ubuntu-specific identifiers and complexity
introduced HWE and such, wireguard-linux-compat develops against the
latest kernels for each of the Ubuntu releases -- listed on
https://www.wireguard.com/build-status/ , ctrl+F for ubuntu. This
already amounts to ~7 kernels. So the thing to do here would be to add
!defined(ISUBUNTU1804) to the relevant ifdef:

#if (LINUX_VERSION_CODE < KERNEL_VERSION(4, 19, 10) &&
LINUX_VERSION_CODE >= KERNEL_VERSION(4, 15, 0) && !defined(ISRHEL8) &&
!defined(ISUBUNTU1804)) || LINUX_VERSION_CODE < KERNEL_VERSION(4, 14,
217)

Afterwards, if you want to apply additional patches downstream so that
this works on older kernels within each Ubuntu release, that would make
sense. But upstream should first always be made to work against the
latest kernel version in each Ubuntu release. If you have advanced
knowledge that something is about to break (because of this or that
backport), then please push a patch upstream for that.

apw@ knows how this works, if you want to talk to somebody internal
about it. Otherwise I'm zx2c4 on Freenode and happy to help.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1915304

Title:
  linux-stable v4.14.217 causes skb_mark_not_on_list() build failure

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/wireguard-linux-compat/+bug/1915304/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to