Thank you! This one is looking pretty solid overall.
But I think the "hex detection" has some flaws, as it only checks for capital 
letters and there is a discrepancy between accepting float hex numbers (which 
is unexpected IMO) but rejecting float octal numbers.

Could you please test for some more edge cases like and make sure they
all work  (and maybe also octal floats):

"0xDEADBEEF" "0xcafe42" "0xdeadbeef" "0xdead.beef" "0x."

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1927078

Title:
  Don't allow useradd to use fully numeric names

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/shadow/+bug/1927078/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to