Hey Andy! So I'm less concerned about the additional devices included as part of the SRU, but more about the additional changes that are pulled in. Since there's also a lot of patches that are unrelated to the actual ID additions. My worry is that we don't have a good test case and regression analysis for those. All those additional patches (like for instance goodixmoc-Remove-internal-cancellable.patch, goodixmoc-Fix- template-struct-for-required-length-calcula.patch etc.) affect a lot of the libfprint code, and we need to know *at least* if these changes don't break any existing devices.
Could we maybe modify the test cases for the both bugs to include a requirement to test the change against at least a few other devices? Like some existing Synaptics, goodix, elan ones? I would like to get this update into stable series as supporting new devices is important. But for so many patches I'd like us to have decent test coverage. Thanks. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1945296 Title: To support goodix fp device [27C6:639C] To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1945296/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
