Review for Package: src:libdecor-0 [Summary] This is a rather small and simple library to draw client side decorations on wayland. Albeit being a pretty new project with only a single, initial release so far, the codebase seems to be in good shape and properly maintained.
MIR team ACK This does not need a security review List of specific binary packages to be promoted to main: libdecor-0-0, libdecor-0-plugin-1-cairo, libdecor-0-dev Specific binary packages built, but NOT to be promoted to main: libdecor-tests (not really needed in main) Notes: This package is in pretty good shape overall. As it is a pretty new library, we should monitor the development initally, to make sure it is not being neglected. It does not touch security critical things, and I guess we can skip security review on this one. Required TODOs: - None Recommended TODOs: - The package should get a team bug subscriber before being promoted (~desktop?) - Improve debian/watch - Work towards improved test coverage in the future - Closely monitor the release cadence of Upstream/Debian/Ubuntu and make sure this package doesn't get neglected [Duplication] There is no other package in main providing the same functionality. [Dependencies] OK: - no other Dependencies to MIR due to this - checked with check-mir - not listed in seeded-in-ubuntu - none of the (potentially auto-generated) dependencies (Depends and Recommends) that are present after build are not in main - no -dev/-debug/-doc packages that need exclusion - No dependencies in main that are only superficially tested requiring more tests now. Problems: None [Embedded sources and static linking] OK: - no embedded source present - no static linking - does not have odd Built-Using entries - not a go package, no extra constraints to consider in that regard Problems: None [Security] OK: - history of CVEs does not look concerning - does not run a daemon as root - does not use webkit1,2 - does not use lib*v8 directly - does not parse data formats - does not open a port/socket - does not process arbitrary web content - does not use centralized online accounts - does not integrate arbitrary javascript into the desktop - does not deal with system authentication (eg, pam), etc) - does not deal with security attestation (secure boot, tpm, signatures) Problems: None [Common blockers] OK: - does not FTBFS currently - does have a test suite that runs as autopkgtest - if a non-trivial test on this level does not make sense (the lib alone is only doing rather simple things), is the overall solution (app+libs) extensively covered i.e. via end to end autopkgtest ? => it is covered in many libsdl2 & libsdl2 user's autopkgtests - no new python2 dependency Problems: - does NOT have a test suite that runs & fails the build - autopkgtest is superficial [Packaging red flags] OK: - Ubuntu does not carry a delta - symbols tracking is in place - d/watch is present and looks ok (if needed, e.g. non-native) - the current release is packaged - promoting this does not seem to cause issues for MOTUs that so far maintained the package - no massive Lintian warnings - d/rules is rather clean - It is not on the lto-disabled list Problems: - Upstream update history is sporadic - Debian/Ubuntu update history is sporadic => This is a very new package (initial release) and it does not have any update history. But there's nothing we can do about that. [Upstream red flags] OK: - no Errors/warnings during the build - no incautious use of malloc/sprintf (as far as we can check it) - no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside tests) - no use of user nobody - no use of setuid - no important open bugs (crashers, etc) in Debian or Ubuntu - no dependency on webkit, qtwebkit, seed or libgoa-* - part of the UI, BUT desktop file not needed, as it is a library - no translation present, but none needed for this case (only non-text)? Problems: None ** Changed in: libdecor-0 (Ubuntu) Status: New => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1952130 Title: [MIR] libdecor-0 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libdecor-0/+bug/1952130/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs