Thanks for the review bdrung.

> 2. Have you forwarded 0002-fail-unitest-when-test-fail.patch and
0003-fix-tests-on-big-endian.patch to upstream?

No, because I would rather be sure this is reviewed and validated before
forwarding.

> 3. A newline at the end of debian/rules is missing.

Thanks, now fixed.

> 4. 0001-utest-autopkgtest.patch is not needed. You can override it
with `make test LIBTRACEEVENT_STATIC="-ltraceevent"`

Well I fixed that, but this is not working and I do not understand why
yet.

> 5. debian/tests/utest is quite small.

Fixed. Indeed this is simpler.

> 6. Have/will you forward your changes to Debian?

Is that the same question as 2? :)


** Patch added: "libtraceevent_1.8.2-1ubuntu1.diff"
   
https://bugs.launchpad.net/ubuntu/+source/libtraceevent/+bug/2055258/+attachment/5756202/+files/libtraceevent_1.8.2-1ubuntu1.diff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2055258

Title:
  No test suite run at built time nor as autopkgtest

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libtraceevent/+bug/2055258/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to