thank you Mauricio for the detailed review! >>It looks like most tests in the requested test_hotplug.py are SKIPPED >>(summary below), so I just wanted to confirm: >> 1) Is that is expected? And
Yes, this skipping is expected on all platforms except for Noble and Ec2 which have a bit more detailed coverage because the platform has better support for automated testing of these features in our integration tests. For the sake of brevity in integration testing I wanted to reference the known integration-test/modules/test_hotplug.py in it's entirety for all platforms as I know the integration tests automatically skip inapplicable tests due to extensive skipIf decorators based on the test platform. Truly, on most platforms the only test we really cared about validating in that integration test module was test_hotplug_enabled_by_cmd. For ec2 though, we have more thorough integration-test support, so we did want to see runs of additional tests including: test_hotplug_enable_cmd_ec2, test_multi_nic_hotplug,test_no_hotplug_triggered_by_docker, test_nics_before_config_trigger_hotplug and test_multi_nic_hotplug_vpc 2) Is the level of confidence sufficient, based on `test_hotplug_enable_cmd`, which is the test that PASSED in all of azure/ec2/gce and lxd_container/lxd_vm? Yes this testing is sufficient because we only need to see that the hotplug.socket/service is working at all because that (plus the full integration test suite of lxd_vm/lxd_container) confirms no systemd ordering cycles present preventing cloud-init-hotplug.* services/sockets from starting and running. The more detailed ec2 hotplug tests assert hotplug specific behavior in more complex hotplug scenarios which is really above and beyond the bug we are checking for here. But, since those tests were easy to trigger, I added that to coverage matrix for validation. Sorry for the suspect additional data/SKIPs which prompted your investigation. But, good question too. Thank you! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2081124 Title: systemd service dependency loop between cloud-init, NetworkManager and dbus To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/2081124/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
