firmware-sof doesn't have an SRU exception[1] that allows it to add such
bulk changes without a specific process.

This bug here claims to be enabling just "cs42l43 and cs35l56 audio on
Intel LNL", but the commit is far more reaching than that claim.

If I look at the previous update[2], only one topology file was
added[3]: sof-tplg-v2.2.13/sof-rpl-cs42l43-l0.tplg

> It would be better to catch up with upstream to have these configuration 
> which can support more 
> configurations we could be missing in the future.

This rationale is not always true. Such a type of update can also bring
with it other bugs, which would mean a regression for ubuntu stable
release users. See [4] for some examples and arguments in favor of
minimal changes.

Why do you claim that bringing in all those other 90+ topology files is better 
and less risky than updating just the one we need to fix this bug? I'm 
definitely not the expert in this package, but I see a huge amount of changes, 
to other pieces of hardware, and I have to wonder:
- how can we be sure we are not regressing all those other sound cards?
- we are testing just "intel NL", what about all the other changes?
- Why can you claim that this update will not affect other hardware? You state, 
in the bug description: "It may break cirrus audio support.". But I see many 
topology files that don't seem to be limited to "cirrus audio".

What is the risk in updating/adding just the files we need for "cs42l43
and cs35l56 audio on Intel LNL"?


1. https://wiki.ubuntu.com/StableReleaseUpdates#Documentation_for_Special_Cases
2. https://launchpad.net/ubuntu/+source/firmware-sof/2023.12.1-1ubuntu1.4
3. 
https://git.launchpad.net/ubuntu/+source/firmware-sof/commit/?h=ubuntu/noble-devel
4. 
https://documentation.ubuntu.com/sru/en/latest/explanation/requirements/#explanation-minimal

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2106394

Title:
  [SRU] enable cs42l43 and cs35l56 audio on Intel LNL

To manage notifications about this bug go to:
https://bugs.launchpad.net/hwe-next/+bug/2106394/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to