Review for Source Package: src:dotnet10

[Summary]
.NET 10 is the latest Long Term Support release of the platform. Like its
predecessors - .NET 8 and .NET 6 - it make sense to include it in main. 

MIR team ACK under the constraint to resolve the below listed required
TODOs and as much as possible having a look at the recommended TODOs.

This does need a security review, so I'll assign ubuntu-security.

List of specific binary packages to be promoted to main:
  - bin:aspnetcore-runtime-10.0
  - bin:aspnetcore-targeting-pack-10.0
  - bin:dotnet-apphost-pack-10.0
  - bin:dotnet-host-10.0
  - bin:dotnet-hostfxr-10.0
  - bin:dotnet-runtime-10.0
  - bin:dotnet-sdk-10.0
  - bin:dotnet-sdk-aot-10.0
  - bin:dotnet-targeting-pack-10.0
  - bin:dotnet-templates-10.0
  - bin:dotnet10
Specific binary packages built, but NOT to be promoted to main:
  - bin:aspnetcore-runtime-dbg-10.0
  - bin:dotnet-runtime-dbg-10.0
  - bin:dotnet-sdk-dbg-10.0
  - bin:dotnet-sdk-10.0-source-built-artifacts


Required TODOs:
#0 - Please have the Foundations team subscribed to the package.
.
Recommended TODOs:
#1 - The absence of symbol tracking is acceptable because all the shared 
libraries seem to be
used only internally. However, bin:dotnet-sdk-aot-10.0 seems to include shlibs 
and headers.
Is it likely to have reverse-dependencies that link against these shlibs? If 
yes, does this call for
symbol tracking?

[Rationale, Duplication and Ownership]
- There is no other package in main providing the same functionality.
  => This is a versioned toolchain package
- A team is committed to own long term maintenance of this package.
- The rationale given in the report seems valid and useful for Ubuntu

[Dependencies]
OK:
- no other runtime Dependencies to MIR due to this
- no other build-time Dependencies with active code in the final binaries to 
MIR due to this
- no -dev/-debug/-doc packages that need exclusion
  => the following binary packages stay in universe:
    bin:aspnetcore-runtime-dbg-10.0
    bin:dotnet-runtime-dbg-10.0
    bin:dotnet-sdk-dbg-10.0
    bin:dotnet-sdk-10.0-source-built-artifacts
- No dependencies in main that are only superficially tested requiring more 
tests now.

Problems: None

[Embedded sources and static linking]
OK:
- no embedded source present
  => Upstream vendors Javascript sources compiled from Typescript. Attempts 
have been made
     to do away with this, but the needed effort is significantly large.
  => Upstream also vendors other projects in src/runtime/src/native/external
- no static linking
- does not have unexpected Built-Using entries
- not a go package, no extra constraints to consider in that regard
- not a rust package, no extra constraints to consider in that regard

Problems: None

[Security]
OK:
- history of CVEs does not look concerning
  => Considering the CVEs against past dotnet versions (6-9), and considering 
that this
  is a toolchain package, the history is not concerning. Upstream releases CVE 
fixes
  on "patch Tuesdays" every month. I would still request a security review.
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats (files [images, video, audio,
  xml, json, asn.1], network packets, structures, ...) from
  an untrusted source.
- does not expose any external endpoint (port/socket/... or similar)
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
- does not deal with cryptography (en-/decryption, certificates, signing, ...)
- this makes appropriate (for its exposure) use of established risk
  mitigation features (dropping permissions, using temporary environments,
  restricted users/groups, seccomp, systemd isolation features,
  apparmor, ...)
  => This is not relevant to dotnet10 because it is language toolchain/runtime 
package.

Problems: None

[Common blockers]
OK:
- does not FTBFS currently
- does have a test suite that runs at build time
  - test suite fails will fail the build upon error.
- does have a non-trivial test suite that runs as autopkgtest
- This does not need special HW for build or test
- no new python2 dependency

Problems: None

[Packaging red flags]
OK:
- Ubuntu does not carry a delta
  => This package does not exist on Debian.
- symbols tracking not applicable for this kind of code because it
  the shared objects are only used internally and no headers made
  available.
  => bin:dotnet-sdk-aot-10.0 seems to be an exception here, making headers 
available.
  This needs further clarification.
- debian/watch is not present but also not needed
  => Though this is a non-native package, no debian/watch is present. The reason
     is documented and acceptable.
- Upstream update history is good
- Ubuntu update history is good
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far maintained 
the package
- no massive Lintian warnings
- debian/rules is rather clean
- It is not on the lto-disabled list

Problems: None

[Upstream red flags]
OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (as far as we can check it)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside tests)
- no use of user 'nobody' outside of tests
- no use of setuid / setgid
  => dotnet applications may use setuid/setgid while forking a new process
- no important open bugs (crashers, etc) in Ubuntu
- no dependency on webkit, qtwebkit or libseed
- not part of the UI for extra checks
- no translation present, but none needed for this case

Problems: None


** Changed in: dotnet10 (Ubuntu Resolute)
     Assignee: Pushkar Kulkarni (pushkarnk) => Ubuntu Security Team 
(ubuntu-security)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2134482

Title:
  [MIR] dotnet10

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/dotnet10/+bug/2134482/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to