# libcufile-13-1 review comments a) d/control has this: Vcs-Browser: https://git.launchpad.net/~canonical-nvidia/+source/+git/libcufile-13-1 Vcs-Git: https://git.launchpad.net/~canonical-nvidia/+source/+git/libcufile-13-1
These are private repositories, and I see that in https://code.launchpad.net/~canonical- nvidia/+git/libcufile-13-1/+merge/502668 they were changed already, so +1. Nothing further to do if the next upload contains the change. b) d/copyright b1) a*/ copyright Fixed in https://code.launchpad.net/~canonical-nvidia/+git/libcufile-13-1/+merge/502668 Nothing further to do if the next upload contains this change. b2) d/copyright mentions cuda samples, but they are not part of this package. I checked cuda-culib, accepted already, and there it's saying that the samples were moved to https://github.com/nvidia/cuda-samples. Did you intend to make the same change here? If yes, are there other changes missing? In any case, the way it is is OK I think, this is just a heads up that I noticed this difference. c) alternatives usage for /etc/cufile.json case "$1" in configure) echo Setting alternatives update-alternatives --install /etc/cufile.json cufile.json /usr/local/cuda-13.1/gds/cufile.json 131 ldconfig ;; esac c1) Any specific reason to call update-alternatives directly in maintainer scripts instead of using debhelper? c2) What is the other package providing /etc/cufile.json that we need alternatives for? I checked with apt-file find, and only found /usr/share/doc/gds-tools/examples/cufile.json from bin:gds-tools, coming from src:nvidia-cuda-toolkit, and that package does not have alternatives usage as far as I can see. d) Why is ldconfig called manually in maintainerscripts? Because the normal ldconfig dpkg trigger doesn't cover /usr/local/cuda*? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2141744 Title: [needs-packaging] cuda-13-1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/2141744/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
