Thank you for the review @ahasenack
# libcufile
b)2) The License NVIDIA-CUDA-Proprietary is copied from the deb files
released by NVIDIA [1]. We have an automation that does so for every
package, we assume NVIDIA has this one right. Then we go over the rest
of the files for the rest of the copyright files.
c1) Again, these maintainer scripts are replicated from NVIDIA's packaging.
Given the timeline, we mirrored what they were doing even when it was not great
- You will surely raise an eyebrow for some of the packages. For example,
cuda-meta-13-1 contains this postinst, which does not contain #DEBHELPER# and
does pretty much nothing:
```
#! /bin/sh
set -e
case "$1" in
configure)
echo Setting alternatives
# update-alternatives --install /usr/local/cuda cuda
/usr/local/cuda-13.1 131
# update-alternatives --install /usr/local/cuda-13 cuda-13
/usr/local/cuda-13.1 131
;;
esac
exit 0
```
This allows us to automate our QA a lot. In the future I want to improve our QA
so that it can still verify that we are running the right thing without
brutally comparing maintainer scripts with NVIDIA.
c2) This file is shipped by other libcufile-13-x packages. This will be
the first one in the main archive, but libcufile-13-2 will follow
libcufile-13-1 shortly. I'm only waiting for this review to end so that
I can apply the same fixes to 13-2 before submitting it.
d) ldconfig is called because we add a file in /etc/ld.so.conf.d/. But I now
realize that dh_makeshlibs will also create a trigger that calls ldconfig,
making the one from the postinst very much probably useless.
What I can do is 1) remove the ldconfig and 2) add some code in our QA to
ignore the fact that NVIDIA calls ldconfig in their postinst and not us. Do you
prefer to see these changes in 13-1 or can it wait 13-2?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2141744
Title:
[needs-packaging] cuda-13-1
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/2141744/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
