NEW review seems fine

Sure the preload handling is invasive, evil and not nice - but it is opt-in and 
provides an otherwise unavailable ability to profile.


Here are some non blocking things that can be fixed in the next upload:

debian/control says the library detects "a Java, Node.js, or .NET
application" — but IIUC the injector also supports other languages
(`src/python.zig`, `src/ruby.zig`). Could it try to either list all of
them, or even better make the sentence "like A, B, C, ..." then you can
but do not need to update too often.

debian/source/lintian-overrides
...
# The source for generating them is documented in the upstream repository.

Yeah, but where exactly - to follow your argument it would be great to have a 
link here as well.
There also are things like 
./unit-test-assets/proc-self-auxv/recreate-proc-self-auxv.sh
 so could things be recreated?
I'll trust you for now but would appreciate a clenaup and a link

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2160027

Title:
  [needs-packaging] FFe: opentelemetry-injector

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/2160027/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to