Gary, if there's a situation where UUID doesn't work, it should be fixed
properly. Please report it as a bug.

Meanwhile, I looked at David's patch and it looks sane, safe and clean.
I guess there is just a resistance to do anything at all with the old
grub-update, it's so ugly and messy and developers are only longing for
people to migrate to grub2, for which these things can be done simpler
and better.

Before I saw David's patch, I had my own patch (see attachment) which is
just a one-liner, it allows people to set "NO_CONVERT_UUID=yes" in
/etc/default/grub. If shorter would be better.

Anyway, looking at convert_kopt_to_uuid() I noticed something that at least 
looks wrong:
   if [ -L "$DEV" ] && readlink "$DEV" | grep -q "^/dev/mapper/"
Shouldn't that be "$root" instead of "$DEV"? $DEV is only set as a side-effect 
in another function, last used when finding the /boot partition. If this is 
intended, it is certainly cowboy programming. But I guess it will break and do 
the wrong thing if /boot is using /dev/mapper and / is not. Just an example of 
the mess.

** Attachment added: "oneliner to end years of frustration"
   http://launchpadlibrarian.net/15089605/update-grub.nouuid.patch

-- 
edgy update-grub destroys kopt
https://bugs.launchpad.net/bugs/62195
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to