On Wednesday 28 October 2009 04:57:01 Peter Kjellerstedt wrote:
> From: Mike Frysinger
> 
> [ cut ]
> 
> > @@ -114,6 +114,8 @@ char got_path[];
> >             while (*path != '\0' && *path != '/') {
> >                     if (new_path > max_path) {
> >                             __set_errno(ENAMETOOLONG);
> > + err:
> > +                           free(allocated_path);
> >                             return NULL;
> 
> Fore readability, wouldn't it be better to put the three lines
> above at the end of the function, and just put another goto err
> here? Or is there some other reason to have the error exit path
> in the middle of the function?

i stated the reason for doing this in the part you "[ cut ]".  it was all of 
two sentences :P.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
uClibc mailing list
uClibc@uclibc.org
http://lists.busybox.net/mailman/listinfo/uclibc

Reply via email to