On 6 February 2013 18:11, Bernhard Reutner-Fischer <rep.dot....@gmail.com> wrote: > > Perhaps Will's suggestion of "generic-syscalls" is fine since the > kernel calls them generic, too. > common-generic overdoes it a bit, i guess, but it does produce a nice > tab-completion conflict with common. > So please rename it to common-generic and also add a hunk to > libc/sysdeps/linux/README to briefly explain what common-generic is.
Fixed > > Reading through the series.. > > I'd prefer if you could not put braces around the parameter of defined, e.g.: > +#if defined(__NR_fstat64) && !defined(__NR_fstat) > +#if defined __NR_fstat64 && !defined __NR_fstat > everywhere in those patches. Fixed > > In ftruncate.c, we nowadays have a couple of OFF helpers in > include/endian.h (IIRC), perhaps you can use those? Thanks. I used the OFF_HI_LO helper. > > /Check if valids fd and valid pointers/s/valids fd/valid fds/ Fixed > > on x86_64 with no threads: > libc/sysdeps/linux/common/fork.c:12:0: error: unterminated #if > sounds like a leftover from a merge-conflict. There is no need for > that __libc_fork for !threads > missing indenting space before define in > +#elif defined(__NR_fork) > +#define __NR___libc_fork __NR_fork All fixed. > > In statfs.c there is also a missing indenting space in the nested #if, > please add those, everywhere. > Also indent the existing ones if you add a surrounding preprocessor > conditional, please. > In the same file you duplicate the extern __typeof, please use just > one before the conditionals. > Done > The __NR_ustat stub is only necessary if defined UCLIBC_SV4_DEPRECATED > Fixed > utime.c only needs fcntl.h and stddef.h for the at path, please move it there. > utimes.c Likewise. Why do you need utime.h in there at all? Fixed Please let me know if you need me to fix anything else or if this branch is good enough for inclusion. -- Regards, Markos Chandras _______________________________________________ uClibc mailing list uClibc@uclibc.org http://lists.busybox.net/mailman/listinfo/uclibc
