Hi Jody, > Feedback for both Andrea and Patrick :-)
:) answering some of it. > But first of all - spot on work :-) Very fun. Would love to see the user > guide updated to cover these? > TTF stuff: > - I have not had a chance to review the patch in details; so cannot speak > for code formatting etc yet > Aside: Usually we bash out an idea here with a wireframe so we can sort out > how to integrate the functionality. > - http://udig.refractions.net/confluence/display/UDIG/Ideas > - http://udig.refractions.net/confluence/display/UDIG/Style+Dialog+Improvement > But for a direct patch like this it is not a trouble. I agree with that, since the patch was small and an addition (not a new concept). Sometimes it is better to get stuff in and force to review it, than wait endlessly for no one having time to review it :) > As for performance / graphics / filtering here is an idea (idea may not > work) > - the fonts are divided into blocks based on some unicode thing, a drop down > box under font could make browsing faster. > - I can only find a method to go from char to block? ie UnicodeBlock.of( > char ) > - the characters have unicode names; making them searchable would let people > find stuff? > - http://download.oracle.com/javase/1.5.0/docs/api/java/lang/Character.html > - http://download.oracle.com/javase/1.5.0/docs/api/java/lang/Character.UnicodeBlock.html > In general for these three new pages: > - I really like some of the new features: > - I would like to see "Simple" removed from these three things as they are > no longer that simple. Yeah, I tend to agree with that. Can't remember why I left simple before, since the aim was an advanced editor. > - style list, rules and preview show duplication between the point, line and > polygon pages. Yes, and was very well thought, is wanted and I would like to keep it like that. Since style is very very very very complex we do not know where it might head to. Also points are very different from lines and polygons. So after a generic start I decided to go separate with every type, so that things can be evolved as needed also in future and changing one would not break others. I have to insist with that, since a generic approach has for example been taken with the themed and simple style editor and honestly I rarely saw a code messed up that much (I think I got my white hair from when I had to fix the themed editor). It is evident that style is one of those things you want to do fast small additions (like Patrick), and if the code is not easy to read (like in the themed editor), things are messed up very quickly. So imho in that case duplicated, clean code makes sense. > - we should be able to arrange for only the line and polygon pages to not be > shown when displaying points? No idea about that. Would be nice if easy. Anyways if you select a wrong one, the tab is disabled. > - I really like the preview; sure wish we could take that out of the way and > put it under the list of style pages Well, the preview works well, but for complex styles there is lot's of work to do yet. Still, I think it is good. > - the rules don't follow the eclipse ui guidelines; need a label (so people > can refer to the "rules" list, and text on the buttons (I know it is very > conservative and boring...), I am also used to seeing the "actions" for a > list on the right hand side; in a specific order (add at the top, moving > stuff up and down, and remove some distance away at the bottom so it is not > accidentally clicked on). > - same deal for the style list No comment on that. I do not have time to work on this. If someone does, be my guest. I will happily review. > - I note that the style list has import and export; that duplicates > functionality at the bottom of the screen - could we remove the import and > export at the bottom of the screen? Nope, those are different. In the style list you can import images, svg and sld and styles are generated from them. Those styles are then saved into an internal library. So that is very different from importing a style to apply it to the layer. Also export is not the same. What the export here does is applying the current style directly to the layer if the layer is filebased, also exporting the contained graphics. So if you have a shapefile aaa.shp and a style that contains 2 images img1.png and img2.jpg, in one click it will create in the same folder of the shapefile an sld file aaa.sld with relative paths for the graphics and also put at the same level teh two images named aaa1.png and aaa2.jpg. In that way the files get "portable". > - could the style list be taken off as an individal style page? am I correct > in thinking it acts as a list of predefined style that can be "imported" > onto the style blackboard? yes and no. The style could rely on field names, so without the possibility to edit it, many styles could be broken. So perhaps better no. > - Style properties: The filter tab? Would it be too much to ask that we use > the fancy filter input with command completion and the function list built > in? An example is on the filter style page? Those style editor were long needed and were funded by ARPA Piemonte for BeeGIS development. Currently we are working on finishing the form editor (which might also be of interest to uDig directy at some point?). Guess the time for doing additions and tweaks to the editor has run out for us, so yeah, try to open a ticket for it. Perhaps at some point it might be added. Ciao, A,drea > > On Mon, Feb 14, 2011 at 7:17 PM, andrea antonello > <[email protected]> wrote: >> >> Hi Patrick, >> your addition rocks. I didn't even know that it would be possible >> change border and fill properties on the truetype font basted styles. >> I really like that. >> >> One thing I noticed is that the editor now takes some time to pop up >> (while the line and polygon are still fast). I guess that might be >> bound to the font scan or table generation? Could that be? I did some >> check, but the font scan takes no time. So probably it is the table >> creation for the images? Any idea about how to handle that so that it >> would take that long at least only the first time (showing progress)? >> >> Anyways you have my +1 to apply the patch. >> >> Ciao, >> Andrea >> >> >> >> On Mon, Feb 14, 2011 at 9:06 AM, andrea antonello >> <[email protected]> wrote: >> > Hi Patrick, >> > I will sure look into it later. Hadn't noticed that there was a patch >> > attached. The screenshot look really nice. >> > >> > Ciao, >> > Andrea >> > >> > On Sun, Feb 13, 2011 at 11:09 PM, Patrick Jessup >> > <[email protected]> wrote: >> >> Hi, >> >> >> >> I have recently started working at Lisasoft and have been trying to add >> >> to the Style Editor so that you will be able to use a true type font >> >> character for a Point in addition to the well known marks and images that >> >> you can use at present (please see the screen shot and patch at >> >> http://jira.codehaus.org/browse/UDIG-1750). >> >> >> >> It would be great if someone could give me some feedback on the patch. >> >> >> >> Thanks, >> >> >> >> Patrick Jessup >> >> >> >> >> >> >> >> >> >> >> >> -----Original Message----- >> >> From: Patrick Jessup (JIRA) [mailto:[email protected]] >> >> Sent: Friday, 11 February 2011 3:53 PM >> >> To: Patrick Jessup >> >> Subject: [jira] Updated: (UDIG-1750) Font Style Editor >> >> >> >> >> >> [ >> >> http://jira.codehaus.org/browse/UDIG-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel >> >> ] >> >> >> >> Patrick Jessup updated UDIG-1750: >> >> --------------------------------- >> >> >> >> Attachment: fontStyleEditor.PNG >> >> udig-1750.patch >> >> >> >>> Font Style Editor >> >>> ----------------- >> >>> >> >>> Key: UDIG-1750 >> >>> URL: http://jira.codehaus.org/browse/UDIG-1750 >> >>> Project: uDIG >> >>> Issue Type: Improvement >> >>> Components: application >> >>> Affects Versions: UDIG 1.2.2 >> >>> Reporter: Patrick Jessup >> >>> Assignee: Patrick Jessup >> >>> Priority: Minor >> >>> Fix For: UDIG 1.2.2 >> >>> >> >>> Attachments: fontStyleEditor.PNG, udig-1750.patch >> >>> >> >>> >> >>> Enabling the use of true type font characters as marks. >> >> >> >> -- >> >> This message is automatically generated by JIRA. >> >> - >> >> If you think it was sent incorrectly contact one of the administrators: >> >> http://jira.codehaus.org/secure/Administrators.jspa >> >> - >> >> For more information on JIRA, see: >> >> http://www.atlassian.com/software/jira >> >> >> >> >> >> >> >> The contents of this email are confidential and may be subject to legal >> >> or professional privilege and copyright. No representation is made that >> >> this >> >> email is free of viruses or other defects. If you have received this >> >> communication in error, you may not copy or distribute any part of it or >> >> otherwise disclose its contents to anyone. Please advise the sender of >> >> your >> >> incorrect receipt of this correspondence. >> >> _______________________________________________ >> >> User-friendly Desktop Internet GIS (uDig) >> >> http://udig.refractions.net >> >> http://lists.refractions.net/mailman/listinfo/udig-devel >> >> >> > >> _______________________________________________ >> User-friendly Desktop Internet GIS (uDig) >> http://udig.refractions.net >> http://lists.refractions.net/mailman/listinfo/udig-devel > > > _______________________________________________ > User-friendly Desktop Internet GIS (uDig) > http://udig.refractions.net > http://lists.refractions.net/mailman/listinfo/udig-devel > > _______________________________________________ User-friendly Desktop Internet GIS (uDig) http://udig.refractions.net http://lists.refractions.net/mailman/listinfo/udig-devel
