Hi Jody / Andrea,

Thanks for the feedback.

I managed to reduce the time it takes for the dialog to display by about half a 
second by packing the first TableColumn and using the same width for the 
remaining seven columns.

Do you see any improvement on your side?

I have updated the patch in Jira:

http://jira.codehaus.org/browse/UDIG-1750

Regards,

Patrick

From: 
[email protected]<mailto:[email protected]>
 
[mailto:[email protected]]<mailto:[mailto:[email protected]]>
 On Behalf Of Jody Garnett
Sent: Tuesday, 15 February 2011 11:28 PM
To: User-friendly Desktop Internet GIS
Subject: Re: [udig-devel] [jira]: (UDIG-1750) Font Style Editor

I am going to return to the original feedback for Patrick; the other topics are 
worth a separate email thread.
TTF stuff:
- I have not had a chance to review the patch in details; so cannot speak
for code formatting etc yet
So what we are looking for here are the normal udig guidelines 
(http://udig.refractions.net/confluence/display/DEV/1+UDIG+Guidelines):
1) sensible defaults; when we switch to this tab is a "good" mark selected by 
default? Perhaps "+" which should be available in most fonts?  The other way to 
handle this is to use dialog settings to remember the last value used.
2) code-template and formatter used
3) does findbugs find anything
4) quick check for exception handling
As for performance / graphics / filtering here is an idea (idea may not work)
We will only worry about the idea if performance actually is a problem. While I 
like the idea of
searching for a symbol by name (or just typing a character) it may be overkill.

Another thing we could look at is if a lazy list; known in swt as a virtual 
table:
- http://publicobject.com/glazedlists/documentation/swt_virtual_tables.html

That way you would only wait for the symbols displayed on the screen...

Jody

________________________________
The contents of this email are confidential and may be subject to legal or 
professional privilege and copyright. No representation is made that this email 
is free of viruses or other defects. If you have received this communication in 
error, you may not copy or distribute any part of it or otherwise disclose its 
contents to anyone. Please advise the sender of your incorrect receipt of this 
correspondence.
_______________________________________________
User-friendly Desktop Internet GIS (uDig)
http://udig.refractions.net
http://lists.refractions.net/mailman/listinfo/udig-devel

Reply via email to