Looks good! I've accepted the pull request, but there's one
inconsistency that wasn't a blocker.
When I select a Service from the catalog, the 'Resource Properties'
item is available under the Data menu. Clicking on it throws an
exception:
java.lang.NullPointerException
at
net.refractions.udig.ui.properties.ProperitesCommandHandler.execute(ProperitesCommandHandler.java:57)
at
org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:293)
...
--
Mark
On 10 August 2012 16:45, Jody Garnett <[email protected]> wrote:
> Okay - managed to fix most of this.
>
> And importantly I have commented out the Document View until naz has it
> finished up.
>
> I am really focused on API changes with the pull request, wanting to ensure
> IDocument and friends are available to be implemented. I have a second
> implementation I need to test the API against before I can consider it
> stable / implementable.
>
> Additional comments inline - and thanks for the detailed feedback it really
> helps.
>
> --
> Jody Garnett
>
> On Thursday, 9 August 2012 at 5:32 PM, Mark Leslie wrote:
>
> First, the documentation isn't enough to get going. It doesn't
> explain the differences between file/link, or Feature Document vs.
> Feature Attachement vs. Shapefile Documents, which makes the document
> describing the mechanics of setting these confusing. I think there
> needs to be an overview section to make it clear what these things
> are.
>
> I think we can make an over view section in "Concepts" and have a small
> intro in the "Working with documents" page.
>
> There are also a number of issues:
> * Feature Document uses relative paths only. When my test shapefile
> had an absolute path it was appended to the path of the shapefile. If
> this is expected behaviour it needs to be made considerably more
> clear.
>
> This is an artefact of the initial implementation, I will let Naz have a
> look at?
>
> * The documentation on how to turn enable documents "Configure hotlink
> attributes" isn't quite clear enough. I was completely unable to get
> it working without pulling Naz over. Having said that, once I had
> done it once, it made sense, so I believe it's a doco issue not a
> usability issue.
>
> Let us revisit this when Document View is ready.
>
> For example, only selecting in the catalog, not in
> the layers view, is a pain. But the needed menu is not called
> "GeoResource Properties" and is only available under the Data menu,
> not the context menu. It should also be stated that a feature needs
> to be selected with the feature selection tool. I know it should be
> self-evident, but since there were changes in the info tool that was
> my first stop. Since Box selection was higher on the list that was my
> second.
>
> I have managed to fix the enablement issues; indeed I was able to fix them
> for Layer and Map as well.
>
> Briefly:
> - command handlers are "activeWhen" <- placed the checks that the selection
> is correct here
> - menu is "visibleWhen" <-- removed the checks here
>
> This way the menus are shown, but are only enabled when a command is around
> and willing to do the work.
>
> I pulled out a few of the classes that make this happen so there is little
> code duplication for brining up an IGeoResource, IService or ILayer property
> dialog.
>
> I also added better placeholder pages for IService and IGeoResource.
>
> Jody
>
>
> _______________________________________________
> User-friendly Desktop Internet GIS (uDig)
> http://udig.refractions.net
> http://lists.refractions.net/mailman/listinfo/udig-devel
>
--
Mark Leslie
Geospatial Software Architect
LISAsoft
-------------------------------------------------------------
Ph: +61 2 8570 5000 Fax: +61 2 8570 5099 Mob: +61
Suite 112, Jones Bay Wharf 19-21 Pirrama Rd Pyrmont NSW 2009
-------------------------------------------------------------
LISAsoft is part of the A2end Group of Companies
http://www.ardec.com.au
http://www.lisasoft.com
http://www.terrapages.com
_______________________________________________
User-friendly Desktop Internet GIS (uDig)
http://udig.refractions.net
http://lists.refractions.net/mailman/listinfo/udig-devel
