Comments inline. TLDR: A few small functionality issues added to the RFC (http://udig.refractions.net/confluence/display/UDIG/Document+View) for later, pull request accepted. > [Naz] Updated layout of view contents. > > > > >
Thanks, that mostly did the trick. > > - Remove the "header" (we only use that header for forms). See InfoView below. > > > [Naz] Removed header > > > > > Nice clean look. > > > - It is a bit tricky to select a feature, and then open DocumentView, often > it only figures things out when I switch focus to the Document view directly. > It should be listening as long as it is visible on screen. > [Naz] Im not sure what’s happening here, the view is listening to the > workbench selection so it should update every time except when you select the > same resource. > > > > > We may have to debug that one later, added as a task to the clean up section. We may need to be a bit more aggressive hunting down the current map, rather then only checking the workbench selection. > > > > > - The "Label" and "Description" text fields are cut off for some reason, and > the dialog is not resizable. > > > [Naz] Not having this in my machine, can you give specific steps? > > > > > Will mark this down for later, the specific step is "Edit…" > > > - OK button should be "Attach" when creating this for the first time - > checking the RFC shows it as "Add" so I am corrected > > > > > Added as a task for later. > > > - Save As should default to the correct "filename"? Usually people just want > to choose a directory … same deal for filename extension should be maintained > if not provided by user. > > > [Naz] Added default filename and adding of extension when the user does not > specify any > > > > > Default filename ends up being "alternate-Copy.sld"? is that expected... > > > - files that are added as attachments are still editable, should be able to > use file setReadOnly to fix this. Attached files can be opened for review, > but need to be saved out using Save As in order to be edited. > > > [Naz] Updated to set files as read-only > > > > > Thanks that helps. > [Naz] Updated functionality of layer documents to the ff: > > - They are now attachments instead of the original sidecar file > design > - Files will be copied to > “/Volumes/Fiore/jody/Data/hotlink/australia.documents” in your sample above > - Updated “Add...” to “Attach...” to align with this change > > > > > I see that, sounds okay. We have the corner case of an add a web link being treated as an attachment but I think that still makes sense. > > To sum-up the current handlings: > - Layer Docs – Done as attachments (copied) > - Feature Docs - Done as attachments (copied) > - Feature Hotlinks – Done as sidecar (linked) > > > > > > Nice
_______________________________________________ User-friendly Desktop Internet GIS (uDig) http://udig.refractions.net http://lists.refractions.net/mailman/listinfo/udig-devel
