On Fri, Jul 10, 2009 at 07:51:49AM +0200, Niels Kristian Bech Jensen wrote: > > > Date: Thu, 9 Jul 2009 08:10:52 +0200 > > From: [email protected] > > To: [email protected] > > Subject: [UFRaw-Devel] preview and writer fix for image rotation. > > > > The patch below shows image rotation (not just flipping) in the preview > > window of ufraw. The only way to specify a rotation is still to modify the > > ID file but at least the preview window is now showing it correctly. There > > are a couple of ways to make this accessible from within the GUI, for > > example let the user draw a line on the horizon in the image but I'll > > leave that for someone else. > > > > The preview code contains lots of references to the initial width,height > > instead of the rotated width,height but in order to keep the patch more > > readable _for_now_ this has been fixed by a #define instead of fixing > > it by search-and-replace. > > > > A cropping bug for rotated images has been fixed in the writer too. > > > I have attached a version of the patch with all the initial{Heigth,Width} -> > rotated{Heigth,Width} conversions done. > > One problem I have found with the patch is that it breaks rotation when > lensfun is used. It is easy to reproduce: > > 1. Build UFRaw with lensfun support and this patch applied. > 2. Load an image file and rotate 90 deg.
This problem can be reproduced in stock 0.15, i.e. without any of my patches. Not all camera/lens corrections do show it. It is at least reproducable with: camera: Canon, EOS 40D lens: Canon, Canon EF-S 10-22mm f/3.5-4.5 USM (top of drop-down list) After loading an image and selecting the above camera+lens, a 90 degree rotate changes the aspect ratio but not all of the image. The zoom-to-fit button seems to correct it but playing around that way quickly shows up bitrot in the preview image and tends to end with SIGSEGV :-( I'd guess some kind of a dangling preview image buffer pointer but with these kind of problems guesses are often wrong. -- Frank ------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge _______________________________________________ ufraw-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ufraw-devel
