When the ID file specifies createID==only_id as in

        <CreateID>2</CreateID>

and I fire up ufraw with this ID file as argument then the save button
does not behave as expected: it also converts and saves the image. It
appears that ufraw silently decides to replace "only_id" by "also_id"
when read from an ID file, see around line 162 in ufraw_ufraw.c

>From the outside this looks like a bug because ufraw is just not doing
what it has been told. Is there any special reason for this "magic"
or can we just remove it?

diff --git a/ufraw.h b/ufraw.h
index 0417abd..4deb25e 100644
--- a/ufraw.h
+++ b/ufraw.h
@@ -149,7 +149,6 @@ typedef struct {
  * CONF|ID: curve/profile are added to the list from RC.
  * CONF: inputFilename, outputFilename are ignored.
  * outputPath can only be specified in CMD or guessed in interactive mode.
- * ID: createID==only_id is switched to also_id.
  * ID: chanMul[] override wb, green, temperature.
  */
 typedef struct {
diff --git a/ufraw_ufraw.c b/ufraw_ufraw.c
index 3f5510f..4e54dc8 100644
--- a/ufraw_ufraw.c
+++ b/ufraw_ufraw.c
@@ -159,7 +159,6 @@ ufraw_data *ufraw_open(char *filename)
            g_free(conf);
            return NULL;
        }
-       if (conf->createID==only_id) conf->createID = also_id;
 
        /* If inputFilename and outputFilename have the same path,
         * then inputFilename is searched for in the path of the ID file.


-- 
Frank

------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time, 
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
ufraw-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ufraw-devel

Reply via email to