> Date: Sun, 12 Jul 2009 11:11:05 +0200
> From: [email protected]
> To: [email protected]
> Subject: [UFRaw-Devel] loading/saving ID file with createid==only doesn't
> work
>
> When the ID file specifies createID==only_id as in
>
> <CreateID>2</CreateID>
>
> and I fire up ufraw with this ID file as argument then the save button
> does not behave as expected: it also converts and saves the image. It
> appears that ufraw silently decides to replace "only_id" by "also_id"
> when read from an ID file, see around line 162 in ufraw_ufraw.c
>
> >From the outside this looks like a bug because ufraw is just not doing
> what it has been told. Is there any special reason for this "magic"
> or can we just remove it?
>
I seems the code is needed to get ufraw-batch to save the image file when given
a ID file as input. The patch attached to this message fix that. It sets
createID to no_id in ufraw-batch since I don't think ufraw-batch should touch
the ID file.
Regards,
Niels Kristian
_________________________________________________________________
Dit GRATIS USB-stik på nettet er vokset til 25 GB! Få Sky Drive nu!
http://www.microsoft.com/danmark/windows/windowslive/products/skydrive.aspx
diff -urN ufraw-0.16cvs/ufraw-batch.c ufraw/ufraw-batch.c
--- ufraw-0.16cvs/ufraw-batch.c 2009-07-10 18:00:10.000000000 +0200
+++ ufraw/ufraw-batch.c 2009-07-14 06:13:49.000000000 +0200
@@ -92,6 +92,7 @@
g_free(uf);
exit(1);
}
+ if (uf->conf->createID==only_id) uf->conf->createID = no_id;
if (ufraw_load_raw(uf)!=UFRAW_SUCCESS) {
exitCode = 1;
ufraw_close(uf);
diff -urN ufraw-0.16cvs/ufraw.h ufraw/ufraw.h
--- ufraw-0.16cvs/ufraw.h 2009-07-10 15:25:45.000000000 +0200
+++ ufraw/ufraw.h 2009-07-14 06:17:58.000000000 +0200
@@ -149,7 +149,6 @@
* CONF|ID: curve/profile are added to the list from RC.
* CONF: inputFilename, outputFilename are ignored.
* outputPath can only be specified in CMD or guessed in interactive mode.
- * ID: createID==only_id is switched to also_id.
* ID: chanMul[] override wb, green, temperature.
*/
typedef struct {
diff -urN ufraw-0.16cvs/ufraw_ufraw.c ufraw/ufraw_ufraw.c
--- ufraw-0.16cvs/ufraw_ufraw.c 2009-07-11 20:15:24.000000000 +0200
+++ ufraw/ufraw_ufraw.c 2009-07-14 06:17:58.000000000 +0200
@@ -159,7 +159,6 @@
g_free(conf);
return NULL;
}
- if (conf->createID==only_id) conf->createID = also_id;
/* If inputFilename and outputFilename have the same path,
* then inputFilename is searched for in the path of the ID file.
------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
ufraw-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ufraw-devel
