On Mon, Aug 24, 2009 at 12:45:08AM +0200, Frank van Maarseveen wrote:
> On Fri, Jul 10, 2009 at 07:55:12AM +0200, Niels Kristian Bech Jensen wrote:
[...]
> > It seems that you have been bitten by this bug:
> >
> > http://sourceforge.net/tracker/?func=detail&aid=2491388&group_id=127649&atid=709086
>
> AFAICS that bug is gone or was never there: the code in ufraw_preview.c
> is clear about that "Never again" will only overwrite the .ufrawrc with
> itself, possibly modifying some non-conversion related parameters which
> are just intended to be remembered.
>
> Also my first report is not correct. It appears to be possible to create
> a .ufrawrc which is harmless for future conversions but it is hard to
> understand how it works, even when studying the source. Though I don't see
> any real bugs the current behavior/interface is vague and a bit illogic.
> Lets consider the save menu and "Save image defaults" within:
>
> Option text CFG->saveConfiguration
> ----------------------------------------------
> Never again disabled_state (0)
> Always enabled_state (1, default!)
> Just this once apply_state (2)
>
> To me, "Never again" means the same as "Just this once" because of
> the "again" word. It would be more clear to name the options "Never",
> "Always" and "Once".
>
> Second, I think it is pointless to keep on saving the current image
> manipulation parameters as the default. And this even happens to be the
> default behavior of ufraw itself (see conf_default.saveConfiguration). As
> a result all new users will be surprised because ufraw and ufraw-batch
> will use saved conversion parameters from any previous random image and
> they will have a hard time finding out and getting rid of it.
>
> Proposal:
> - Change conf_default.saveConfiguration to "disabled_state"
> - Rephrase option text.
diff --git a/ufraw_conf.c b/ufraw_conf.c
index ac0a848..edf6eae 100644
--- a/ufraw_conf.c
+++ b/ufraw_conf.c
@@ -101,7 +101,7 @@ const conf_data conf_default = {
/* GUI settings */
25.0, 4, TRUE, /* Zoom, Scale, LockAspect */
- enabled_state, /* saveConfiguration */
+ disabled_state, /* saveConfiguration */
rgb_histogram, /* histogram */
linear_histogram, /* liveHistogramScale */
linear_histogram, /* rawHistogramScale */
diff --git a/ufraw_preview.c b/ufraw_preview.c
index 173cf37..34b0697 100644
--- a/ufraw_preview.c
+++ b/ufraw_preview.c
@@ -4995,9 +4995,9 @@ static void save_fill_interface(preview_data *data,
_("Save current image manipulation parameters as defaults.\n"
"The output parameters in this window are always saved."));
GtkComboBox *confCombo = GTK_COMBO_BOX(gtk_combo_box_new_text());
- gtk_combo_box_append_text(confCombo, _("Never again"));
+ gtk_combo_box_append_text(confCombo, _("Never"));
gtk_combo_box_append_text(confCombo, _("Always"));
- gtk_combo_box_append_text(confCombo, _("Just this once"));
+ gtk_combo_box_append_text(confCombo, _("Once"));
uf_combo_box_set_data(confCombo, &CFG->saveConfiguration);
gtk_box_pack_start(GTK_BOX(hBox), GTK_WIDGET(confCombo),
FALSE, FALSE, 0);
--
Frank
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
ufraw-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ufraw-devel
