On Wed, Sep 16, 2009 at 05:55:26PM -0500, Udi Fuchs wrote: > > Apparently render_prepare() called ufraw_developer_prepare() which > > destroyed a special 0x10000 value in uf->developer->rgbWB[] in case > > of an unshrinked conversion, see ufraw_convert_image_first_phase() for > > this. > > I must say that I am impressed that your simple patch does give 100% > preview. Unfortunately, it is not enough. Any modification to the > profile (such as exposure, white balance curves etc.) do not show up
I missed that. My worry was not breaking display profiles and I didn't want to just hack around what render_prepare() fouls-up. But I'm sure there's a fix without the problems you mention. I'll look into it. The display profile code moved by the patch still troubles me. I haven't been able to test it yet: first thing I'd like to do is to break it such that I can see when it actually makes a difference. Neither create_base_image() or render_prepare() looks the right place for this code. It's too low level and it should be connected to GUI events. -- Frank ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ ufraw-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ufraw-devel
