On Thu, Sep 17, 2009 at 02:47:10PM -0500, Udi Fuchs wrote: > > Here's take two. The white balancing has been removed from > > dcraw_finalize_interpolate(), together with the hack to compensate > > for that again. This consolidates the path for WB because > > dcraw_finalize_shrink() doesn't do that either. > > White balance has to be applied before interpolation, otherwise you > get interpolation artifacts.
There are other issues at the pixel level to worry about (maze artifacts, noise speckles) and most is not even visible in the GUI just because of the limited zoom. We need a magnifying glass for this anyway considering the dot pitch of modern screens. The amount of hackery necessary to implement different WB paths consistently depending on shrink or not is horrible. So, WB should be pushed down into both finalize routines and no longer be done by develop() et.al. Parameterizing it using the developer mode makes it no longer WYSIWYG so that's no alternative IMO. > > A compromise for the preview could be to apply WB once in > create_base_image() and then apply changes in WB relative to the > original one. Of course this would only make the WB logic more > complicated. For now, disabling WB during 100% zoom would be enough. I'd think some form of WB is essential anyhow. One of my intermediate test implementations leaves the WB inside dcraw_finalize_interpolate() but results in "Raw histogram with conversion curves" being either utter bogus or obviously wrong, depending on the amount of hackery deployed. This is visible every time zoom is switched to or from 100%. develop() needs to be hacked to get this completely right and I decided that the result would become way too ugly. These kind of hacks tend to haunt development/maintenance for years in my experience. Pushing WB down into both finalize routines should solve this issue. -- Frank ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ ufraw-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ufraw-devel
