> Date: Tue, 6 Oct 2009 09:56:52 +0200
> From: [email protected]
> To: [email protected]
> Subject: [UFRaw-Devel] bug in wavelet_denoise_INDI()
>
> In dcraw_indi.c, the local matrix window_mem[4][width] is used but never
> initialized. The code depends on
>
> if (filters && colors == 3) { /* pull G1 and G3 closer together */
>
> and the strange part is that this code should be applied to the images
> from my D80 camera according to comment (it has RGBG) but not in reality:
> the test is wrong somehow because colors is always 4 and filters is
> either 0 or 0x4b4b4b4b.
>
This patch gets rid of window_mem. Please test it carefully and report back.
The original problem causing the change in the first place was on 64-bit
multi-processor systems.
Regards,
Niels Kristian
_________________________________________________________________
Nej, det er ikke svært at samle alle vennerne fra Hotmail, Myspace og Facebook
på Messenger. Læs mere her
http://www.microsoft.com/danmark/windows/windowslive/import-friends/--- ufraw.cvs/dcraw_indi.c 2009-10-06 05:30:13.000000000 +0200
+++ ufraw/dcraw_indi.c 2009-10-06 18:19:09.000000000 +0200
@@ -178,9 +178,8 @@
if (filters && colors == 3) { /* pull G1 and G3 closer together */
for (row=0; row < 2; row++)
mul[row] = 0.125 * pre_mul[FC(row+1,0) | 1] / pre_mul[FC(row,0) | 1];
- ushort window_mem[4][width];
for (i=0; i < 4; i++)
- window[i] = window_mem[i]; /*(ushort *) fimg + width*i;*/
+ window[i] = (ushort *) fimg + width*i;
for (wlast=-1, row=1; row < height-1; row++) {
while (wlast < row+1) {
for (wlast++, i=0; i < 4; i++)
------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
ufraw-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ufraw-devel
