First off I would like to say appsonly is great. On Nov 20, 2009, at 8:40 AM, Gerhard Hofmann wrote:
> Hi all, > > a while ago I suggested to add some lines to todo.pl... > > elsif ($product_name eq 'Windows Vista (TM) Business') { > $os = 'vista'; > } > elsif ($product_name eq 'Windows Vista (TM) Ultimate') { > $os = 'vista'; > } > > ... because otherwise my appsonly script wouldn't have worked on > Vista. > > See > http://www.mail-archive.com/unattended-info@lists.sourceforge.net/msg06628.html > > The suggested changes were added to the CVS / SVN, but in the > meantime I > stumbled upon further product name strings not handled by todo.pl. > > Examples: > Windows (TM) Vista Ultimate > Windows 7 Ultimate > Windows 7 Home Premium > Microsoft Windows Server (R) 2008 Standard > Windows Server 2008 R2 Standard > > Because MS makes so many different editions of their products, it's > very > difficult to "catch all" in todo.pl > > Maybe it would be a good idea to do substring instead of exact string > matches? > > Like this: > $product_name contains "Vista" --> $os = "vista" > $product_name contains "2008" --> $os = "win2008" I vote for this approach It seems the most manageable. > Second idea: > Change the line > die "Unrecognized $pn_key: $product_name"; > to > $os = 'unknown_os'; I also think that it would be reasonable to add the second suggestion to the sites file Just my 2 cents. Thanks for apps only, Ben > > My appsonly script would have no problem with that, but could that > break > things for people doing operating system + applications installs? > > Regards > Gerhard > > > > > > > > > ------------------------------------------------------------------------------ > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 > 30-Day > trial. Simplify your report design, integration and deployment - and > focus on > what you do best, core application coding. Discover what's new with > Crystal Reports now. http://p.sf.net/sfu/bobj-july > _______________________________________________ > unattended-info mailing list > unattended-info@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/unattended-info ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ unattended-info mailing list unattended-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/unattended-info