Stan Pitucha <stan.pitu...@envato.com> wrote: > > I only saw one issue (proposed fix below). > Sorry, I solved the other one while writing the email but forgot to > update the intro. > > So the fix worked for the issue I mentioned, thanks! Also, running > unicorn directly works just fine now.
You're welcome and thanks for following up! > I ran into another regression with unicorn_rails though. We're doing > some work in `after_fork` which relies on a class found in > `lib/logger_switcher.rb`. Unfortunately it looks like the scope > changed and now I get workers respawning in a loop: > > E, [2019-03-06T15:03:04.990789 #46680] ERROR -- : uninitialized > constant #<Class:#<Unicorn::Configurator:0x00007fc3d113d098>>::LoggerSwitcher > (NameError) Is this with `preload_app true`? I'm not too up-to-date with scoping and namespace behavior stuff, actually. I'm too tired at the moment, maybe Jeremy can help figure this out. > config/unicorn.rb:97:in `block in reload' > /Users/viraptor/.rbenv/versions/2.5.3/lib/ruby/gems/2.5.0/gems/unicorn-5.5.0/lib/unicorn/http_server.rb:653:in > `init_worker_process' > /Users/viraptor/.rbenv/versions/2.5.3/lib/ruby/gems/2.5.0/gems/unicorn-5.5.0/lib/unicorn/http_server.rb:681:in > `worker_loop' > /Users/viraptor/.rbenv/versions/2.5.3/lib/ruby/gems/2.5.0/gems/unicorn-5.5.0/lib/unicorn/http_server.rb:548:in > `spawn_missing_workers' > /Users/viraptor/.rbenv/versions/2.5.3/lib/ruby/gems/2.5.0/gems/unicorn-5.5.0/lib/unicorn/http_server.rb:562:in > `maintain_worker_count' > /Users/viraptor/.rbenv/versions/2.5.3/lib/ruby/gems/2.5.0/gems/unicorn-5.5.0/lib/unicorn/http_server.rb:295:in > `join' > /Users/viraptor/.rbenv/versions/2.5.3/lib/ruby/gems/2.5.0/gems/unicorn-5.5.0/bin/unicorn_rails:209:in > `<top (required)>' > bin/unicorn_rails:17:in `load' > bin/unicorn_rails:17:in `<main>' > E, [2019-03-06T15:03:04.992143 #46194] ERROR -- : reaped > #<Process::Status: pid 46680 exit 1> worker=1 > > The LoggerSwitcher was previously resolved by rails automatically. -- unsubscribe: unicorn-public+unsubscr...@bogomips.org archive: https://bogomips.org/unicorn-public/
