On 03/06 04:44, Eric Wong wrote:
> Stan Pitucha <[email protected]> wrote:
> > > I only saw one issue (proposed fix below).
> > Sorry, I solved the other one while writing the email but forgot to
> > update the intro.
> >
> > So the fix worked for the issue I mentioned, thanks! Also, running
> > unicorn directly works just fine now.
>
> You're welcome and thanks for following up!
>
> > I ran into another regression with unicorn_rails though. We're doing
> > some work in `after_fork` which relies on a class found in
> > `lib/logger_switcher.rb`. Unfortunately it looks like the scope
> > changed and now I get workers respawning in a loop:
> >
> > E, [2019-03-06T15:03:04.990789 #46680] ERROR -- : uninitialized
> > constant
> > #<Class:#<Unicorn::Configurator:0x00007fc3d113d098>>::LoggerSwitcher
> > (NameError)
>
> Is this with `preload_app true`? I'm not too up-to-date
> with scoping and namespace behavior stuff, actually.
This is just a guess, but we probably want to call the Unicorn.builder
lambda with the same arguments as the rails_builder lambda.
diff --git a/bin/unicorn_rails b/bin/unicorn_rails
index ea4f822..354c1df 100755
--- a/bin/unicorn_rails
+++ b/bin/unicorn_rails
@@ -132,11 +132,11 @@ def rails_builder(ru, op, daemonize)
# this lambda won't run until after forking if preload_app is false
# this runs after config file reloading
- lambda do ||
+ lambda do |x, server|
# Rails 3 includes a config.ru, use it if we find it after
# working_directory is bound.
::File.exist?('config.ru') and
- return Unicorn.builder('config.ru', op).call
+ return Unicorn.builder('config.ru', op).call(x, server)
# Load Rails and (possibly) the private version of Rack it bundles.
begin
If that doesn't fix it, keep reading.
If after_fork is referencing LoggerSwitcher, and preload_app is not set,
then I think the failure should be expected, as in that case after_fork
is called before build_app!. That would not explain a regression,
though, as that behavior should have been true in 5.4.1.
Does the problem go away if you switch after_fork to after_worker_ready?
Is preload_app set to true?
Thanks,
Jeremy
--
unsubscribe: [email protected]
archive: https://bogomips.org/unicorn-public/
